Ability to remove sponsor link form "Become a XXX Sponsor!" #294
Conversation
| @@ -22,7 +22,7 @@ team: ["Harm Boertien", "Thomas Krag", "Kerim Satirli", "Arjan Wolfs", "Wilco No | |||
| organizer_email: "[email protected]" # Put your organizer email address here | |||
| proposal_email: "[email protected]" # Put your proposal email address here | |||
|
|
|||
| # Sponsors 2016-sendachi | |||
There was a problem hiding this comment.
Removed this stray comment from the amsterdam event data as they aren't a sponsor and it was a remnant of another yml file I looked at for inspiration.
|
Thanks! It's common to sell out of one type of sponsorship and still be signing others up. This would ideally be an optional flag on each specific sponsorship level. See also #93. |
|
Let me take a stab at it on my plane ride in the coming hours! |
| @@ -19,7 +19,7 @@ | |||
| {{ end }} | |||
| {{ end }} | |||
| {{ if eq $e.status "current" }} | |||
| {{ if eq $e.sponsor_link_ask "closed" }} | |||
| {{ if eq $e.sponsors_accepted "closed" }} | |||
There was a problem hiding this comment.
I think this will be easier to understand if instead of "closed"/"open" it's "yes"/"no" (as seen in the yaml file above).
There was a problem hiding this comment.
Yup. You're right. I missed that in my branch.
On Sunday, 8 May 2016, Bridget Kromhout [email protected] wrote:
In themes/devopsdays-legacy/layouts/partials/event_footer.html
#294 (comment)
:@@ -19,7 +19,7 @@
{{ end }}
{{ end }}
{{ if eq $e.status "current" }}
{{ if eq $e.sponsor_link_ask "closed" }}{{ if eq $e.sponsors_accepted "closed" }}I think this will be easier to understand if instead of "closed"/"open"
it's "yes"/"no" (as seen in the yaml file above).—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/devopsdays/devopsdays-web/pull/294/files/298fb56f8b9e7ebfa4a7daf67db5b9017f0f5228..19b2cba09de8fbaf11a50fb0c68cca5594eb5ac3#r62431741
Yvo van Doorn — Manager, Technical Services (EMEA)
+31 6 38 74 07 46 <+316740746> – [email protected] – *my: *Linkedin
http://www.linkedin.com/in/yvovandoorn/ Twitter
https://twitter.com/yvov
CHEF
CHEF.IO http://www.chef.io/
TM
chef.io http://www.chef.io/ Blog http://www.chef.io/blog/ Facebook
https://www.facebook.com/getchefdotcom Twitter
https://twitter.com/chef Youtube https://www.youtube.com/getchef
|
airport commits merging to branch. struggling with how to do the logic on when not present link when |
|
Ok so the logic / idea behind turning it off city/event wide makes sense and I've updated the PR as such. The biggest challenge I've been having with Hugo (and thus my limits) is how the logic around how to compare Given this is my 4th day with Hugo (or Go in general) so far I've come this far: My struggles: Is how to properly add up the levels set under sponsors.level against sponsor_levels.max. Example I have 4 sponsors: How do I count up the id 'gold' being used 3x under sponsors to fire off against (greater than or equal to) under sponsor_levels.max:2. Feels like there is a loop in involved and the sysadmin in me to use unix commands to determine the comparison. Obviously not appropriate here. |
|
This PR looks great, @yvovandoorn - thanks! I'll move the discussion of the additional work into #93. |
…oclosesponsor Ability to remove sponsor link form "Become a XXX Sponsor!" Former-commit-id: 9ea1759
Ability to remove sponsor link form "Become a XXX Sponsor!"
Ability to remove sponsor link form "Become a XXX Sponsor!"
Ability to remove sponsor link form "Become a XXX Sponsor!" Former-commit-id: 9ea1759
Ability to remove sponsor link form "Become a XXX Sponsor!"
Ability to remove sponsor link form "Become a XXX Sponsor!" Former-commit-id: 9ea1759
Introduces a new option: `sponsor_link_ask' to have the ability to turn off the "Become a XXX Sponsor!" feature.
As this is an "opt_in" feature, as "it doesn't change default behavior", only those events that want to use the option will see its benefit.